api/grpc_server: Remove redundant loop for gRPC server

gRPC server should try to start serving only once because it send
stopped signal to the waiter if server could not start.

This patch removes redundant "for" loop to improve code inspection
result.

Signed-off-by: IWASE Yusuke <iwase.yusuke0@gmail.com>

1 files changed, 12 insertions, 13 deletions

diff --git a/api/grpc_server.go b/api/grpc_server.go
index a359f761..21b9d260 100644
--- a/api/grpc_server.go
+++ b/api/grpc_server.go
@@ -64,25 +64,24 @@ func (s *Server) Serve() error {
 	wg.Add(len(l))
 
 	serve := func(host string) {
-		for {
-			defer wg.Done()
-			lis, err := net.Listen("tcp", fmt.Sprintf(host))
-			if err != nil {
-				log.WithFields(log.Fields{
-					"Topic": "grpc",
-					"Key":   host,
-					"Error": err,
-				}).Warn("listen failed")
-				return
-			}
-			err = s.grpcServer.Serve(lis)
+		defer wg.Done()
+		lis, err := net.Listen("tcp", fmt.Sprintf(host))
+		if err != nil {
 			log.WithFields(log.Fields{
 				"Topic": "grpc",
 				"Key":   host,
 				"Error": err,
-			}).Warn("accept failed")
+			}).Warn("listen failed")
+			return
 		}
+		err = s.grpcServer.Serve(lis)
+		log.WithFields(log.Fields{
+			"Topic": "grpc",
+			"Key":   host,
+			"Error": err,
+		}).Warn("accept failed")
 	}
+
 	for _, host := range l {
 		go serve(host)
 	}