rpki: Collect detailed information while validating

Signed-off-by: Satoshi Fujimoto <satoshi.fujimoto7@gmail.com>

2 files changed, 42 insertions, 13 deletions

diff --git a/server/rpki.go b/server/rpki.go
index a93decb8..dab3d442 100644
--- a/server/rpki.go
+++ b/server/rpki.go
@@ -489,9 +489,17 @@ func (c *roaManager) GetRoa(family bgp.RouteFamily) ([]*table.ROA, error) {
 	return l, nil
 }
 
-func ValidatePath(ownAs uint32, tree *radix.Tree, cidr string, asPath *bgp.PathAttributeAsPath) (config.RpkiValidationResultType, *RoaBucket) {
+func ValidatePath(ownAs uint32, tree *radix.Tree, cidr string, asPath *bgp.PathAttributeAsPath) (*table.Validation, *RoaBucket) {
 	var as uint32
 
+	validation := &table.Validation{
+		Status:          config.RPKI_VALIDATION_RESULT_TYPE_NOT_FOUND,
+		Reason:          table.RPKI_VALIDATION_REASON_TYPE_NONE,
+		Matched:         make([]*table.ROA, 0),
+		UnmatchedLength: make([]*table.ROA, 0),
+		UnmatchedAs:     make([]*table.ROA, 0),
+	}
+
 	if asPath == nil || len(asPath.Value) == 0 {
 		as = ownAs
 	} else {
@@ -506,7 +514,7 @@ func ValidatePath(ownAs uint32, tree *radix.Tree, cidr string, asPath *bgp.PathA
 		case bgp.BGP_ASPATH_ATTR_TYPE_CONFED_SET, bgp.BGP_ASPATH_ATTR_TYPE_CONFED_SEQ:
 			as = ownAs
 		default:
-			return config.RPKI_VALIDATION_RESULT_TYPE_NOT_FOUND, nil
+			return validation, nil
 		}
 	}
 	_, n, _ := net.ParseCIDR(cidr)
@@ -515,23 +523,42 @@ func ValidatePath(ownAs uint32, tree *radix.Tree, cidr string, asPath *bgp.PathA
 	key := table.IpToRadixkey(n.IP, prefixLen)
 	_, b, _ := tree.LongestPrefix(key)
 	if b == nil {
-		return config.RPKI_VALIDATION_RESULT_TYPE_NOT_FOUND, nil
+		return validation, nil
 	}
 
-	result := config.RPKI_VALIDATION_RESULT_TYPE_INVALID
 	var bucket *RoaBucket
 	fn := radix.WalkFn(func(k string, v interface{}) bool {
 		bucket, _ = v.(*RoaBucket)
 		for _, r := range bucket.entries {
-			if prefixLen <= r.MaxLen && r.AS != 0 && r.AS == as {
-				result = config.RPKI_VALIDATION_RESULT_TYPE_VALID
-				return true
+			if prefixLen <= r.MaxLen {
+				if r.AS != 0 && r.AS == as {
+					validation.Matched = append(validation.Matched, r)
+				} else {
+					validation.UnmatchedAs = append(validation.UnmatchedAs, r)
+				}
+			} else {
+				validation.UnmatchedLength = append(validation.UnmatchedLength, r)
 			}
 		}
 		return false
 	})
 	tree.WalkPath(key, fn)
-	return result, bucket
+
+	if len(validation.Matched) != 0 {
+		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_VALID
+		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_NONE
+	} else if len(validation.UnmatchedAs) != 0 {
+		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_INVALID
+		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_AS
+	} else if len(validation.UnmatchedLength) != 0 {
+		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_INVALID
+		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_LENGTH
+	} else {
+		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_NOT_FOUND
+		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_NONE
+	}
+
+	return validation, bucket
 }
 
 func (c *roaManager) validate(pathList []*table.Path) {
@@ -545,8 +572,8 @@ func (c *roaManager) validate(pathList []*table.Path) {
 			continue
 		}
 		if tree, ok := c.Roas[path.GetRouteFamily()]; ok {
-			r, _ := ValidatePath(c.AS, tree, path.GetNlri().String(), path.GetAsPath())
-			path.SetValidation(config.RpkiValidationResultType(r))
+			v, _ := ValidatePath(c.AS, tree, path.GetNlri().String(), path.GetAsPath())
+			path.SetValidation(v)
 		}
 	}
 }
diff --git a/server/rpki_test.go b/server/rpki_test.go
index 34b9a237..694883e7 100644
--- a/server/rpki_test.go
+++ b/server/rpki_test.go
@@ -21,11 +21,13 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/armon/go-radix"
+	"github.com/stretchr/testify/assert"
+
+	radix "github.com/armon/go-radix"
+
 	"github.com/osrg/gobgp/config"
 	"github.com/osrg/gobgp/packet/bgp"
 	"github.com/osrg/gobgp/table"
-	"github.com/stretchr/testify/assert"
 )
 
 func strToASParam(str string) *bgp.PathAttributeAsPath {
@@ -56,7 +58,7 @@ func strToASParam(str string) *bgp.PathAttributeAsPath {
 
 func validateOne(tree *radix.Tree, cidr, aspathStr string) config.RpkiValidationResultType {
 	r, _ := ValidatePath(65500, tree, cidr, strToASParam(aspathStr))
-	return r
+	return r.Status
 }
 
 func TestValidate0(t *testing.T) {