From 22c16a8b71d6ba3d5dc9c4ec1343c9abceb38837 Mon Sep 17 00:00:00 2001
From: Matt Johnston <matt@ucc.asn.au>
Date: Thu, 7 Apr 2011 13:25:00 +0000
Subject: Clean up fd on failure. Found by Klocwork

--HG--
extra : convert_revision : 4b999175c8e91ee3ddf283b17525999499a12849
---
 svr-agentfwd.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

(limited to 'svr-agentfwd.c')

diff --git a/svr-agentfwd.c b/svr-agentfwd.c
index 054a3b5..3010503 100644
--- a/svr-agentfwd.c
+++ b/svr-agentfwd.c
@@ -50,10 +50,7 @@ static void agentaccept(struct Listener * listener, int sock);
 /* Handles client requests to start agent forwarding, sets up listening socket.
  * Returns DROPBEAR_SUCCESS or DROPBEAR_FAILURE */
 int svr_agentreq(struct ChanSess * chansess) {
-
-	int fd;
-
-	TRACE(("enter svr_agentreq"))
+	int fd = -1;
 
 	if (!svr_pubkey_allows_agentfwd()) {
 		return DROPBEAR_FAILURE;
@@ -91,10 +88,9 @@ int svr_agentreq(struct ChanSess * chansess) {
 	}
 
 	return DROPBEAR_SUCCESS;
-	TRACE(("success"))
 
 fail:
-	TRACE(("fail"))
+	m_close(fd);
 	/* cleanup */
 	svr_agentcleanup(chansess);
 
-- 
cgit v1.2.3