From 55ed5531b5ec99792154f1e82ccccdc8d23abbca Mon Sep 17 00:00:00 2001
From: Matt Johnston <matt@ucc.asn.au>
Date: Sun, 4 Feb 2007 10:44:07 +0000
Subject: Revert bogus fix, make a note that the var is meant to 'leak'

--HG--
extra : convert_revision : e0efd546c3cdb2828971e41af2afe43e850c641d
---
 cli-runopts.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'cli-runopts.c')

diff --git a/cli-runopts.c b/cli-runopts.c
index d8eada7..269f5b3 100644
--- a/cli-runopts.c
+++ b/cli-runopts.c
@@ -348,7 +348,8 @@ static void addforward(char* origstr, struct TCPFwdList** fwdlist) {
 
 	TRACE(("enter addforward"))
 
-	/* We probably don't want to be editing argvs */
+	/* We need to split the original argument up. This var
+	   is never free()d. */ 
 	str = m_strdup(origstr);
 
 	listenport = str;
@@ -400,8 +401,6 @@ static void addforward(char* origstr, struct TCPFwdList** fwdlist) {
 	newfwd->next = *fwdlist;
 	*fwdlist = newfwd;
 
-	m_free(str);
-
 	TRACE(("leave addforward: done"))
 	return;
 
-- 
cgit v1.2.3