From 5cb54b5adcda45c71120ec93c0bbbd558703a218 Mon Sep 17 00:00:00 2001 From: Denis Vlasenko Date: Tue, 21 Oct 2008 17:14:26 +0000 Subject: init: downgrade ENABLE_DEBUG_INIT to just a #define to prevent people from selecting it in error. It has to be used ONLY for debugging init, never in production, as resulting init has serious differences. --- init/Config.in | 8 -------- init/init.c | 10 +++++++--- 2 files changed, 7 insertions(+), 11 deletions(-) (limited to 'init') diff --git a/init/Config.in b/init/Config.in index 6a45e7d3d..6b5799fe3 100644 --- a/init/Config.in +++ b/init/Config.in @@ -12,14 +12,6 @@ config INIT help init is the first program run when the system boots. -config DEBUG_INIT - bool "Debugging aid" - default n - depends on INIT - help - Turn this on to disable all the dangerous - rebooting stuff when debugging. - config FEATURE_USE_INITTAB bool "Support reading an inittab file" default y diff --git a/init/init.c b/init/init.c index e00a3b128..ae2dd6a7a 100644 --- a/init/init.c +++ b/init/init.c @@ -14,6 +14,10 @@ #include #include +/* Was a CONFIG_xxx option. A lot of people were building + * not fully functional init by switching it on! */ +#define DEBUG_INIT 0 + #define COMMAND_SIZE 256 #define CONSOLE_NAME_SIZE 32 #define MAXENV 16 /* Number of env. vars */ @@ -103,7 +107,7 @@ static void loop_forever(void) * "where" may be bitwise-or'd from L_LOG | L_CONSOLE * NB: careful, we can be called after vfork! */ -#define messageD(...) do { if (ENABLE_DEBUG_INIT) message(__VA_ARGS__); } while (0) +#define messageD(...) do { if (DEBUG_INIT) message(__VA_ARGS__); } while (0) static void message(int where, const char *fmt, ...) __attribute__ ((format(printf, 2, 3))); static void message(int where, const char *fmt, ...) @@ -275,7 +279,7 @@ static void open_stdio_to_tty(const char* tty_name, int exit_on_failure) tty_name, strerror(errno)); if (exit_on_failure) _exit(EXIT_FAILURE); - if (ENABLE_DEBUG_INIT) + if (DEBUG_INIT) _exit(2); /* NB: we don't reach this if we were called after vfork. * Thus halt_reboot_pwoff() itself need not be vfork-safe. */ @@ -788,7 +792,7 @@ int init_main(int argc UNUSED_PARAM, char **argv) return kill(1, SIGHUP); } - if (!ENABLE_DEBUG_INIT) { + if (!DEBUG_INIT) { /* Expect to be invoked as init with PID=1 or be invoked as linuxrc */ if (getpid() != 1 && (!ENABLE_FEATURE_INITRD || !strstr(applet_name, "linuxrc")) -- cgit v1.2.3