summaryrefslogtreecommitdiffhomepage
path: root/include
diff options
context:
space:
mode:
authorRon Yorston <rmy@tigress.co.uk>2012-04-28 17:04:19 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2012-04-28 17:04:19 +0200
commit576b1d3c417ddea79481063401837ec0bdb91658 (patch)
tree10ad0b85a5fa746442c3ad6e3607709f86d16aa6 /include
parent0c62f20454b55a932d59c50b7418b8b634a8a23f (diff)
sendmail: use host rather than NIS domain name for HELO
According to RFC 5321 the argument to HELO "contains the fully-qualified domain name of the SMTP client" or its IP address if no FQDN is available. BusyBox sendmail uses the NIS domain name instead which, in many cases, is likely to be the default "(none)". [vda: yes, I checked my machine and its uts.domainname was indeed "(none)"] Using the host name is more likely to satisfy the intent of the RFC while allowing the otherwise unused safe_getdomainname function to be removed. Signed-off-by: Ron Yorston <rmy@tigress.co.uk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'include')
-rw-r--r--include/libbb.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/include/libbb.h b/include/libbb.h
index 2cc146631..f12800f53 100644
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -795,7 +795,6 @@ void qsort_string_vector(char **sv, unsigned count) FAST_FUNC;
int safe_poll(struct pollfd *ufds, nfds_t nfds, int timeout_ms) FAST_FUNC;
char *safe_gethostname(void) FAST_FUNC;
-char *safe_getdomainname(void) FAST_FUNC;
/* Convert each alpha char in str to lower-case */
char* str_tolower(char *str) FAST_FUNC;