From 6d1ae197d189d50e60279796441c6e74272ddc54 Mon Sep 17 00:00:00 2001 From: Ondrej Zajicek Date: Sun, 1 Jan 2023 20:10:23 +0100 Subject: Nest: Fix several issues with pflags There were some confusion about validity and usage of pflags, which caused incorrect usage after some flags from (now removed) protocol- specific area were moved to pflags. We state that pflags: - Are secondary data used by protocol-specific hooks - Can be changed on an existing route (in contrast to copy-on-write for primary data) - Are irrelevant for propagation (not propagated when changed) - Are specific to a routing table (not propagated by pipe) The patch did these fixes: - Do not compare pflags in rte_same(), as they may keep cached values like BGP_REF_STALE, causing spurious propagation. - Initialize pflags to zero in rte_get_temp(), avoid initialization in protocol code, fixing at least two forgotten initializations (krt and one case in babel). - Improve documentation about pflags --- proto/rpki/rpki.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'proto/rpki/rpki.c') diff --git a/proto/rpki/rpki.c b/proto/rpki/rpki.c index 3c27aa1a..3e321627 100644 --- a/proto/rpki/rpki.c +++ b/proto/rpki/rpki.c @@ -130,8 +130,6 @@ rpki_table_add_roa(struct rpki_cache *cache, struct channel *channel, const net_ rta *a = rta_lookup(&a0); rte *e = rte_get_temp(a, p->p.main_source); - e->pflags = 0; - rte_update2(channel, &pfxr->n, e, e->src); } -- cgit v1.2.3