From b28431e557c4f63923476094a919a0630001275e Mon Sep 17 00:00:00 2001 From: Ondrej Zajicek Date: Tue, 3 Jan 2023 17:01:54 +0100 Subject: Nest: Fix leaking internal attributes in RIP and Babel During backporting attribute changes from 3.0-branch, some internal attributes (RIP iface and Babel seqno) leaked to 'show route all' output. Allow protocols to hide specific attributes with GA_HIDDEN value. Thanks to Nigel Kukard for the bugreport. --- nest/protocol.h | 1 + nest/rt-attr.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) (limited to 'nest') diff --git a/nest/protocol.h b/nest/protocol.h index 46744357..fcbf0539 100644 --- a/nest/protocol.h +++ b/nest/protocol.h @@ -94,6 +94,7 @@ void protos_dump_all(void); #define GA_UNKNOWN 0 /* Attribute not recognized */ #define GA_NAME 1 /* Result = name */ #define GA_FULL 2 /* Result = both name and value */ +#define GA_HIDDEN 3 /* Attribute should not be printed */ /* * Known protocols diff --git a/nest/rt-attr.c b/nest/rt-attr.c index 22b45db9..d793c72e 100644 --- a/nest/rt-attr.c +++ b/nest/rt-attr.c @@ -981,7 +981,9 @@ ea_show(struct cli *c, const eattr *e) bsprintf(pos, "", e->type); } } - cli_printf(c, -1012, "\t%s", buf); + + if (status != GA_HIDDEN) + cli_printf(c, -1012, "\t%s", buf); } /** -- cgit v1.2.3