summaryrefslogtreecommitdiff
path: root/sysdep/linux
diff options
context:
space:
mode:
authorOndrej Zajicek (work) <santiago@crfreenet.org>2016-03-23 18:25:15 +0100
committerOndrej Zajicek (work) <santiago@crfreenet.org>2016-04-06 11:46:25 +0200
commite86cfd41d975122cc944db68383aef4028da9575 (patch)
tree55da71e1a9132480391fc5b7045dec8228a214d2 /sysdep/linux
parentea0a8be2ff5afb8385a69cc0df70984e0fd3a570 (diff)
KRT: Fix route learn scan when route changed
When a kernel route changed, function krt_learn_scan() noticed that and replaced the route in internal kernel FIB, but after that, function krt_learn_prune() failed to propagate the new route to the nest, because it confused the new route with the (removed) old best route and decided that the best route did not changed. Wow, the original code (and the bug) is almost 17 years old.
Diffstat (limited to 'sysdep/linux')
-rw-r--r--sysdep/linux/netlink.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sysdep/linux/netlink.c b/sysdep/linux/netlink.c
index 640d1877..1ffdff07 100644
--- a/sysdep/linux/netlink.c
+++ b/sysdep/linux/netlink.c
@@ -1102,7 +1102,8 @@ nl_parse_route(struct nlmsghdr *h, int scan)
e->net = net;
e->u.krt.src = src;
e->u.krt.proto = i->rtm_protocol;
- e->u.krt.type = i->rtm_type;
+ e->u.krt.seen = 0;
+ e->u.krt.best = 0;
e->u.krt.metric = 0;
if (a[RTA_PRIORITY])