diff options
| author | Ondrej Zajicek <santiago@crfreenet.org> | 2023-01-01 20:10:23 +0100 |
|---|---|---|
| committer | Ondrej Zajicek <santiago@crfreenet.org> | 2023-01-01 20:10:23 +0100 |
| commit | 6d1ae197d189d50e60279796441c6e74272ddc54 (patch) | |
| tree | 15ee0c85132678db20042b9d07d75a412da93031 /proto/static | |
| parent | 8b06a4d8af46511f0f8dbb8905afa88590a831b6 (diff) | |
Nest: Fix several issues with pflags
There were some confusion about validity and usage of pflags, which
caused incorrect usage after some flags from (now removed) protocol-
specific area were moved to pflags.
We state that pflags:
- Are secondary data used by protocol-specific hooks
- Can be changed on an existing route (in contrast to copy-on-write
for primary data)
- Are irrelevant for propagation (not propagated when changed)
- Are specific to a routing table (not propagated by pipe)
The patch did these fixes:
- Do not compare pflags in rte_same(), as they may keep cached values
like BGP_REF_STALE, causing spurious propagation.
- Initialize pflags to zero in rte_get_temp(), avoid initialization in
protocol code, fixing at least two forgotten initializations (krt
and one case in babel).
- Improve documentation about pflags
Diffstat (limited to 'proto/static')
| -rw-r--r-- | proto/static/static.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/proto/static/static.c b/proto/static/static.c index cd31afd3..bb93305e 100644 --- a/proto/static/static.c +++ b/proto/static/static.c @@ -104,7 +104,6 @@ static_announce_rte(struct static_proto *p, struct static_route *r) /* We skip rta_lookup() here */ rte *e = rte_get_temp(a, src); - e->pflags = 0; if (r->cmds) { |