summaryrefslogtreecommitdiff
path: root/proto/ospf
diff options
context:
space:
mode:
authorOndrej Zajicek (work) <santiago@crfreenet.org>2018-10-25 17:22:37 +0200
committerOndrej Zajicek (work) <santiago@crfreenet.org>2018-10-25 17:22:37 +0200
commit0ac9cb2c1f6592290e025f61ccd0fef0dc09de46 (patch)
treede13ebe898fce50ac9ac01bde639f9523923e630 /proto/ospf
parentdf50598f1c285a5e2820b7427998c6ebf86bbbec (diff)
OSPF: Fix some trace messages
Missing argument in MTU change trace message can crash bird when MTU change happens and trace messages are active. Thanks to Alexander Velkov for the bugreport.
Diffstat (limited to 'proto/ospf')
-rw-r--r--proto/ospf/hello.c2
-rw-r--r--proto/ospf/iface.c3
2 files changed, 3 insertions, 2 deletions
diff --git a/proto/ospf/hello.c b/proto/ospf/hello.c
index 523c24ad..9e427c4f 100644
--- a/proto/ospf/hello.c
+++ b/proto/ospf/hello.c
@@ -290,7 +290,7 @@ ospf_receive_hello(struct ospf_packet *pkt, struct ospf_iface *ifa,
if (!ipa_equal(faddr, n->ip))
{
OSPF_TRACE(D_EVENTS, "Neighbor %R on %s changed IP address to %I",
- n->rid, ifa->ifname, n->ip, faddr);
+ n->rid, ifa->ifname, faddr);
n->ip = faddr;
}
}
diff --git a/proto/ospf/iface.c b/proto/ospf/iface.c
index 19bcfa15..54a355b6 100644
--- a/proto/ospf/iface.c
+++ b/proto/ospf/iface.c
@@ -1278,7 +1278,8 @@ ospf_iface_change_mtu(struct ospf_proto *p, struct ospf_iface *ifa)
{
/* ifa is not vlink */
- OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d", ifa->iface->mtu);
+ OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d",
+ ifa->ifname, ifa->iface->mtu);
ifa->tx_length = ifa_tx_length(ifa);