summaryrefslogtreecommitdiff
path: root/proto/bgp/attrs.c
diff options
context:
space:
mode:
authorMaria Matejka <mq@ucw.cz>2023-03-29 18:55:46 +0200
committerMaria Matejka <mq@ucw.cz>2023-04-04 17:00:58 +0200
commit2898f8f1771dedf4e385a5c0333da03e55d5decb (patch)
tree1dea2011099d6df0fc1459ad8665c358fca73321 /proto/bgp/attrs.c
parentadbce76517f53e06243ed954b20172cc1313d5c3 (diff)
BGP: LLGR Staleness optimization dropped.
This brought unnecessary complexity into the decision procedures while the performance aspects weren't worth it. It just saved one ea_list traversal when many others are also done.
Diffstat (limited to 'proto/bgp/attrs.c')
-rw-r--r--proto/bgp/attrs.c20
1 files changed, 1 insertions, 19 deletions
diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c
index a0d2f4d6..8dc5ac3e 100644
--- a/proto/bgp/attrs.c
+++ b/proto/bgp/attrs.c
@@ -2280,24 +2280,8 @@ bgp_get_neighbor(rte *r)
static inline int
rte_stale(rte *r)
{
- if (r->pflags & BGP_REF_STALE)
- return 1;
-
- if (r->pflags & BGP_REF_NOT_STALE)
- return 0;
-
- /* If staleness is unknown, compute and cache it */
eattr *a = ea_find(r->attrs, BGP_EA_ID(BA_COMMUNITY));
- if (a && int_set_contains(a->u.ptr, BGP_COMM_LLGR_STALE))
- {
- r->pflags |= BGP_REF_STALE;
- return 1;
- }
- else
- {
- r->pflags |= BGP_REF_NOT_STALE;
- return 0;
- }
+ return a && int_set_contains(a->u.ptr, BGP_COMM_LLGR_STALE);
}
int
@@ -2702,8 +2686,6 @@ bgp_rte_modify_stale(struct rt_export_request *req, const net_addr *n, struct rt
/* Mark the route as LLGR */
rte e0 = *r;
bgp_set_attr_ptr(&e0.attrs, BA_COMMUNITY, flags, int_set_add(tmp_linpool, ad, BGP_COMM_LLGR_STALE));
- e0.pflags &= ~BGP_REF_NOT_STALE;
- e0.pflags |= BGP_REF_STALE;
/* We need to update the route but keep it stale. */
ASSERT_DIE(irh->stale_set == irh->stale_valid + 1);