diff options
| author | Maria Matejka <mq@ucw.cz> | 2022-05-15 18:09:30 +0200 |
|---|---|---|
| committer | Maria Matejka <mq@ucw.cz> | 2022-05-30 14:39:09 +0200 |
| commit | 950775f6fa3d569a9d7cd05e33538d35e895d688 (patch) | |
| tree | 81b4b23d5695e209301b252d0d282b05a0d67ac1 /proto/bgp/attrs.c | |
| parent | 4fe9881d625f10e44109a649e369a413bd98de71 (diff) | |
Route destination field merged with nexthop attribute; splitting flowspec validation result out.
As there is either a nexthop or another destination specification
(or othing in case of ROAs and Flowspec), it may be merged together.
This code is somehow quirky and should be replaced in future by better
implementation of nexthop.
Also flowspec validation result has its own attribute now as it doesn't
have anything to do with route nexthop.
Diffstat (limited to 'proto/bgp/attrs.c')
| -rw-r--r-- | proto/bgp/attrs.c | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c index 1efc26ce..6a9e4026 100644 --- a/proto/bgp/attrs.c +++ b/proto/bgp/attrs.c @@ -1711,9 +1711,20 @@ bgp_preexport(struct proto *P, rte *e) if (src == NULL) return 0; - /* Reject flowspec that failed validation */ - if ((e->attrs->dest == RTD_UNREACHABLE) && net_is_flow(e->net->n.addr)) - return -1; + /* Reject flowspec that failed or are pending validation */ + if (net_is_flow(e->net->n.addr)) + switch (rt_get_flowspec_valid(e)) + { + case FLOWSPEC_VALID: + break; + case FLOWSPEC_INVALID: + return -1; + case FLOWSPEC_UNKNOWN: + if ((rt_get_source_attr(e) == RTS_BGP) && + ((struct bgp_channel *) e->sender)->base_table) + return -1; + break; + } /* IBGP route reflection, RFC 4456 */ if (p->is_internal && src->is_internal && (p->local_as == src->local_as)) |