diff options
| author | Ondrej Zajicek (work) <santiago@crfreenet.org> | 2018-10-25 17:21:06 +0200 |
|---|---|---|
| committer | Ondrej Zajicek (work) <santiago@crfreenet.org> | 2018-10-25 17:21:06 +0200 |
| commit | fff79b1c1e0577f487b4fb67f79a74b054d734b6 (patch) | |
| tree | c10af392cbf8152002be62b426bb3206c2945e46 | |
| parent | c0fc3e67185c1e0ff2d083572c6ad3983ba4ef25 (diff) | |
OSPF: Fix some trace messages
Missing argument in MTU change trace message can crash bird when MTU
change happens and trace messages are active.
Thanks to Alexander Velkov for the bugreport.
| -rw-r--r-- | proto/ospf/hello.c | 2 | ||||
| -rw-r--r-- | proto/ospf/iface.c | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/proto/ospf/hello.c b/proto/ospf/hello.c index e00487dc..7f14b636 100644 --- a/proto/ospf/hello.c +++ b/proto/ospf/hello.c @@ -283,7 +283,7 @@ ospf_receive_hello(struct ospf_packet *pkt, struct ospf_iface *ifa, if (!ipa_equal(faddr, n->ip)) { OSPF_TRACE(D_EVENTS, "Neighbor %R on %s changed IP address to %I", - n->rid, ifa->ifname, n->ip, faddr); + n->rid, ifa->ifname, faddr); n->ip = faddr; } } diff --git a/proto/ospf/iface.c b/proto/ospf/iface.c index 1795ec22..6e3a48b3 100644 --- a/proto/ospf/iface.c +++ b/proto/ospf/iface.c @@ -1256,7 +1256,8 @@ ospf_iface_change_mtu(struct ospf_proto *p, struct ospf_iface *ifa) { /* ifa is not vlink */ - OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d", ifa->iface->mtu); + OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d", + ifa->ifname, ifa->iface->mtu); ifa->tx_length = ifa_tx_length(ifa); |