From 5787bb38d60bda3bcada741353016ca328f116f0 Mon Sep 17 00:00:00 2001 From: Matthew Miller Date: Sun, 25 Jun 2023 11:01:53 -0700 Subject: Add test for absence of getters --- .../browser/src/methods/startRegistration.test.ts | 25 +++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) (limited to 'packages/browser/src') diff --git a/packages/browser/src/methods/startRegistration.test.ts b/packages/browser/src/methods/startRegistration.test.ts index f8c0e5a..e27099d 100644 --- a/packages/browser/src/methods/startRegistration.test.ts +++ b/packages/browser/src/methods/startRegistration.test.ts @@ -250,7 +250,7 @@ test('should return authenticatorAttachment if present', async () => { expect(response.authenticatorAttachment).toEqual('cross-platform'); }); -test('should return convenience values if present', async () => { +test('should return convenience values if getters present', async () => { /** * I call them "convenience values" because the getters for public key algorithm, * public key bytes, and authenticator data are alternative ways to access information @@ -277,6 +277,29 @@ test('should return convenience values if present', async () => { expect(response.response.authenticatorData).toEqual('AAAAAA'); }); +test('should not return convenience values if getters missing', async () => { + /** + * I call them "convenience values" because the getters for public key algorithm, + * public key bytes, and authenticator data are alternative ways to access information + * that's already buried in the response. + */ + // Mock extension return values from authenticator + mockNavigatorCreate.mockImplementation((): Promise => { + return new Promise(resolve => { + resolve({ + response: {}, + getClientExtensionResults: () => { }, + }); + }); + }); + + const response = await startRegistration(goodOpts1); + + expect(response.response.publicKeyAlgorithm).toBeUndefined(); + expect(response.response.publicKey).toBeUndefined(); + expect(response.response.authenticatorData).toBeUndefined(); +}); + describe('WebAuthnError', () => { describe('AbortError', () => { const AbortError = generateCustomError('AbortError'); -- cgit v1.2.3